Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal support for fods #3

Merged
merged 4 commits into from
Jul 25, 2017
Merged

Add minimal support for fods #3

merged 4 commits into from
Jul 25, 2017

Conversation

jonadem
Copy link
Contributor

@jonadem jonadem commented Jul 25, 2017

@codecov-io
Copy link

codecov-io commented Jul 25, 2017

Codecov Report

Merging #3 into master will decrease coverage by 0.74%.
The diff coverage is 91.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage    97.7%   96.96%   -0.75%     
==========================================
  Files          12       13       +1     
  Lines         609      691      +82     
==========================================
+ Hits          595      670      +75     
- Misses         14       21       +7
Impacted Files Coverage Δ
pyexcel_odsr/__init__.py 100% <100%> (ø) ⬆️
tests/test_fods_reader.py 100% <100%> (ø)
pyexcel_odsr/odsr.py 93.58% <87.5%> (-1.65%) ⬇️
pyexcel_odsr/messyods.py 92.56% <90.74%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a263e86...c427ba9. Read the comment docs.

@chfw
Copy link
Member

chfw commented Jul 25, 2017

Superb. Thanks for your PR.

@chfw chfw merged commit 2e868df into pyexcel:master Jul 25, 2017
chfw added a commit that referenced this pull request Jul 25, 2017
chfw added a commit that referenced this pull request Jul 25, 2017
chfw added a commit that referenced this pull request Jul 25, 2017
@chfw
Copy link
Member

chfw commented Jul 25, 2017

due to the limitation of github, I could not upstream my changes to pending PR for messy tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants